[skip changelog] Remove obsolete go generate directive #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the early days of Arduino CLI's gRPC interface, the protocol buffer compilation was done via `go generate`, configured by a directive comment. The `protoc:compile` task is now used instead, but the old directive was left in place, where it became outdated through changes to the repository structure. This directive no longer functions or serves a purpose and might cause confusion to contributors. So it should be removed.
silvanocerza
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)bug fix
In the early days of Arduino CLI's gRPC interface, the protocol buffer compilation was done via
go generate, configuredby a directive comment. The
protoc:compiletask is now used instead, but the old directive was left in place, where it became outdated through changes to the repository structure.This directive no longer functions or serves a purpose and might cause confusion to contributors. So it should be removed.
The useless directive is removed.
titled accordingly?
no break